Remove extra logging, add additional task for removing npm versions and remove use of versioning plugin#238
Merged
labkey-susanh merged 11 commits intodevelopfrom Dec 11, 2025
Merged
Conversation
labkey-tchad
approved these changes
Dec 8, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
If this doesn't work on Windows, maybe we could use the JGit library used by our VCS license tool? https://github.com/LabKey/tools/blob/develop/vcslicense/src/org/labkey/vcslicense/VCSLicense.java
Contributor
Author
Good thought to keep in mind. Fortunately, indications are that it does work on Windows as currently written. |
labkey-adam
approved these changes
Dec 10, 2025
| ### TBD | ||
| ### 7.X.X | ||
| *Released*: TBD | ||
| (Earliest compatible LabKey version: 25.10) |
Contributor
Author
There was a problem hiding this comment.
I think this should still be compatible with 25.10 since the presence of the versioning plugin version shouldn't cause problems; we simply won't be using it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
module.xmlfile without the (dying) versioning pluginRelated Pull Requests
Changes
PurgeNpmVersionstask